feat(client): add GetEndpointHost utility getter #347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parkedwards
requested a deployment
to
Acceptance Tests
GitHub Actions
Waiting
parkedwards
force-pushed
the
hooks-endpoint
branch
from
f7f29df to
527116d
Compare
parkedwards
requested a deployment
to
Acceptance Tests
GitHub Actions
Waiting
parkedwards
changed the title
parkedwards
commented
Dec 24, 2024
| @@ -6,6 +6,8 @@ import "github.com/google/uuid" | |||
| // | |||
| //nolint:interfacebloat // we'll accept a larger PrefectClient interface | |||
| type PrefectClient interface { | |||
| GetEndpointHost() string | |||
There was a problem hiding this comment.
todo: add a comment string that differentiates the client factories from a new category of methods like this one
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves https://linear.app/prefect/issue/PLA-841/extract-path-suffix-less-api-endpoint-into-webhook-resource
resolves #333
this PR adds an endpointHost (host only, so no prefix) attribute to the PrefectClient, as well as a getter method on the interface. we use this to construct the full webhook endpoint, since the API only stashes the slug portion, and we'll want to expose a fully formed endpoint based on the API that the provider is initialized with