Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Initial Webhook resource & data source scaffolding #251

Closed
wants to merge 7 commits into from

Conversation

armalite
Copy link
Contributor

@armalite armalite commented Aug 28, 2024

Adds Webhook resource and data source to the Prefect terraform provider

  • Implements client functions for Webhook endpoint
  • Implements the resource and data source definitions

TODO: Still a work in progress. Needs tidying up + add tests

Related to #261

@armalite
Copy link
Contributor Author

Still a draft. Happy to close and re-raise when closer to done if that's preferred 😄

@armalite armalite changed the title Add Webhook resource & data source feat: Add Webhook resource & data source Aug 28, 2024
@mitchnielsen
Copy link
Contributor

Thanks for contributing! Leaving it here in Draft works for us. Helps us see progress and lend a hand if needed 👍🏼

@armalite
Copy link
Contributor Author

armalite commented Sep 27, 2024

Been a bit busy - I'll get back on this during October November December/January
I'll reserve some time during the EOY break to get some movement on this 🤞🏼

@parkedwards
Copy link
Contributor

hey @armalite -- are there any plans on progressing this branch? If not, we can take it on and steer it home

@parkedwards parkedwards self-assigned this Dec 16, 2024
@parkedwards parkedwards marked this pull request as ready for review December 16, 2024 19:48
@parkedwards parkedwards requested a review from a team as a code owner December 16, 2024 19:48
@armalite
Copy link
Contributor Author

Hey @parkedwards – sorry for the delay, it's been a busy few months. I was planning to revisit this late December or early January, but you're absolutely welcome to take over the PR or merge it into your own branch if you'd like to complete it. 😊

@parkedwards parkedwards changed the title feat: Add Webhook resource & data source feat: Initial Webhook resource & data source scaffolding Dec 16, 2024
@parkedwards
Copy link
Contributor

awesome - i've combined your commits to this new PR #332 (i couldn't push the golint fixes and other standardizations to your current branch, so I created a new one that preserved your commits)

i'll be closing this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants