Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update prefect-aws docs #16639

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Update prefect-aws docs #16639

wants to merge 5 commits into from

Conversation

seanpwlms
Copy link
Contributor

This more explicitly documents how to create the various prefect-aws blocks, adds more examples, reorganizes a few things, and updates some language.

Checklist

  • This pull request references any related issue by including "closes <link to issue>"
    • If no issue exists and your change is not a small fix, please create an issue first.
  • If this pull request adds new functionality, it includes unit tests that cover the changes
  • If this pull request removes docs files, it includes redirect settings in mint.json.
  • If this pull request adds functions or classes, it includes helpful docstrings.

@github-actions github-actions bot added the docs label Jan 8, 2025
discdiver
discdiver reviewed Jan 8, 2025
View reviewed changes
Copy link
Contributor

@discdiver discdiver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! One suggestion.

docs/integrations/prefect-aws/index.mdx Outdated
return glue_job_run.wait_for_completion()


example_run_glue_job()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wadda ya think about and if name = main block here and later?

@seanpwlms seanpwlms requested a review from discdiver January 8, 2025 16:52
discdiver
discdiver reviewed Jan 8, 2025
View reviewed changes
Copy link
Contributor

@discdiver discdiver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Made extra line breaks suggestion before function call to match black requirements.

docs/integrations/prefect-aws/index.mdx Show resolved Hide resolved
docs/integrations/prefect-aws/index.mdx Show resolved Hide resolved
@seanpwlms seanpwlms requested a review from discdiver January 8, 2025 17:05
discdiver
discdiver approved these changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@discdiver discdiver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TY!

@discdiver
Copy link
Contributor

looks like pre-commit hook failure is unrelated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@discdiver discdiver discdiver approved these changes

@cicdw cicdw Awaiting requested review from cicdw cicdw is a code owner

@desertaxle desertaxle Awaiting requested review from desertaxle desertaxle is a code owner

@zzstoatzz zzstoatzz Awaiting requested review from zzstoatzz zzstoatzz is a code owner

Assignees
No one assigned
Labels
docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seanpwlms @discdiver