Add GitHub workflow for releases #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a new GitHub workflow for releases that will: - Upload the CRDs and default CR manifest - Build and push the docker image Closes #18
mitchnielsen
force-pushed
the
add-releases
branch
from
f5bc2c8 to
4b56d23
Compare
|
Still pretty new to GitHub Actions so going to try to simulate a release here to ensure this all works. Welcoming any suggested changes here too. |
mitchnielsen
commented
Aug 30, 2024
mitchnielsen
commented
Aug 30, 2024
Specifies the image path to use for released manifests: prefecthq/prefect-operator:<tag>.
For pull requests, will build and push an image named `prefecthq/prefect-operator-dev`. Also gates the artifact upload action to releases only.
Also ensured these labels exist in the project settings.
Adds comments explaining the 'dev' and 'prod' environments setup, and that certain resources are managed in Terraform. [skip ci]
|
The pull request scenario looks good, and after merging we can test a real release workflow with something like Open to any feedback on this setup as I learn GitHub actions, even just stylistic things 👍🏼 |
chrisguidry
approved these changes
Sep 5, 2024
jamiezieziula
approved these changes
Sep 5, 2024
parkedwards
reviewed
Sep 5, 2024
parkedwards
reviewed
Sep 5, 2024
|
Oh one quick thing, can we make the release jobs depend on the tests? |
Good shout, looking into this now Edit: got this set up: 
|
- Adds pre-commit configuration - Adds yamllint and actionlint - Applies fixes they recommend
- Moves unit-tests job into main workflow - Now enables us to rely on unit-tests passing to proceed
The tag event type should give us better consistency between the docker-metadata step and the release asset upload step.
mitchnielsen
force-pushed
the
add-releases
branch
from
38da3c1 to
c9fbdc9
Compare
chrisguidry
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds a new GitHub workflow for releases that will:
Closes https://linear.app/prefect/issue/PLA-220/design-release-process
Closes #18
Testing
docker pull prefecthq/prefect-operator-dev:pr-58