Support setting extra args in Deployment command #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Supports setting extra args in the Deployment command. This will allow us to set `--no-ui` in cases where we don't need to serve the UI. Related to https://linear.app/prefect/issue/PLA-452/cycle-5-catch-all
jimid27
reviewed
Nov 1, 2024
| @@ -281,7 +284,10 @@ func (s *PrefectServer) Image() string { | |||
| } | |||
|
|
|||
| func (s *PrefectServer) Command() []string { | |||
| return []string{"prefect", "server", "start", "--host", "0.0.0.0"} | |||
| command := []string{"prefect", "server", "start", "--host", "0.0.0.0"} | |||
| command = append(command, s.Spec.ExtraArgs...) | |||
There was a problem hiding this comment.
would this really be extraCommands since args are their own field in k8s?
There was a problem hiding this comment.
hmmm. technically yes, but here we're shoving args into the command field and not specifying any args directly, even though everything after the first one is an arg 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supports setting extra args in the Deployment command.
This will allow us to set
--no-uiin cases where we don't need to serve the UI.Related to https://linear.app/prefect/issue/PLA-452/cycle-5-catch-all