feat(IGN): add activity #9233
Open
feat(IGN): add activity #9233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darkvillager2
suggested changes
Feb 5, 2025
websites/I/IGN/IGN.json
Outdated
Comment on lines
6
to
13
| "IGN.buttonViewWiki": { | ||
| "description": "Used as the title for the button in Discord.", | ||
| "message": "View Wiki" | ||
| }, | ||
| "IGN.playlists": { | ||
| "description": "Playlists on IGN are lists with games.", | ||
| "message": "Viewing Playlists" | ||
| }, |
There was a problem hiding this comment.
@Bas950 these could be a general string imo
There was a problem hiding this comment.
@darkvillager2 make a pr for it, they are in this repo
websites/I/IGN/IGN.json
Outdated
Comment on lines
50
to
53
| "IGN.viewGame": { | ||
| "description": "", | ||
| "message": "Viewing game:" | ||
| }, |
websites/I/IGN/IGN.json
Outdated
Comment on lines
54
to
57
| "IGN.buttonViewGame": { | ||
| "description": "Used as the title for the button in Discord.", | ||
| "message": "View Game" | ||
| }, |
3 tasks
darkvillager2
suggested changes
Feb 5, 2025
Co-authored-by: github plz bring back DarkVIllager <[email protected]> Signed-off-by: Bruno Ramos <[email protected]>
Co-authored-by: github plz bring back DarkVIllager <[email protected]> Signed-off-by: Bruno Ramos <[email protected]>
Co-authored-by: github plz bring back DarkVIllager <[email protected]> Signed-off-by: Bruno Ramos <[email protected]>
Co-authored-by: github plz bring back DarkVIllager <[email protected]> Signed-off-by: Bruno Ramos <[email protected]>
Co-authored-by: github plz bring back DarkVIllager <[email protected]> Signed-off-by: Bruno Ramos <[email protected]>
Co-authored-by: github plz bring back DarkVIllager <[email protected]> Signed-off-by: Bruno Ramos <[email protected]>
Co-authored-by: github plz bring back DarkVIllager <[email protected]> Signed-off-by: Bruno Ramos <[email protected]>
Co-authored-by: github plz bring back DarkVIllager <[email protected]> Signed-off-by: Bruno Ramos <[email protected]>
Co-authored-by: github plz bring back DarkVIllager <[email protected]> Signed-off-by: Bruno Ramos <[email protected]>
Co-authored-by: github plz bring back DarkVIllager <[email protected]> Signed-off-by: Bruno Ramos <[email protected]>
darkvillager2
suggested changes
Feb 5, 2025
Co-authored-by: github plz bring back DarkVIllager <[email protected]> Signed-off-by: Bruno Ramos <[email protected]>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
ESLint found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Acknowledgements
yarn formatScreenshots
Proof showing the creation/modification is working as expected