This repository was archived by the owner on May 15, 2018. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 8
Add Password parameter, and change Test-TargetResource to match the Subj... #3
Open
mcraig88
wants to merge
1
commit into
PowerShellOrg:master
Choose a base branch
from
mcraig88:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -70,21 +70,45 @@ function Set-TargetResource | |
[parameter()] | ||
[ValidateSet('Present','Absent')] | ||
[string] | ||
$Ensure = 'Present' | ||
$Ensure = 'Present', | ||
[parameter()] | ||
[string] | ||
$Password | ||
) | ||
|
||
$CertificateBaseLocation = "cert:\$Location\$Store" | ||
|
||
if ($Ensure -like 'Present') | ||
{ | ||
Write-Verbose "Adding $path to $CertificateBaseLocation." | ||
Import-PfxCertificate -CertStoreLocation $CertificateBaseLocation -FilePath $Path | ||
{ | ||
write-verbose "Is Password Null: $($password -eq $null)" | ||
|
||
if ($password -ne $null){ | ||
write-verbose "Import PFX Cert using password" | ||
if ((Get-WmiObject Win32_OperatingSystem | select -ExpandProperty Version) -eq "6.3.9600"){ | ||
write-verbose "Windows 2012 detected" | ||
$SPassword = ($Password | ConvertTo-SecureString -AsPlainText -Force) | ||
Import-PfxCertificate -CertStoreLocation $CertificateBaseLocation -FilePath $Path -Password $SPassword | ||
}else{ | ||
write-verbose "Windows 2008 detected" | ||
certutil -f -importpfx -p $Password $Path | ||
} | ||
}else | ||
{ | ||
write-verbose "Import PFX Cert without using password" | ||
if ((Get-WmiObject Win32_OperatingSystem | select -ExpandProperty Version) -eq "6.3.9600"){ | ||
write-verbose "Windows 2012 detected" | ||
Import-PfxCertificate -CertStoreLocation $CertificateBaseLocation -FilePath $Path | ||
}else{ | ||
write-verbose "Windows 2008 detected" | ||
certutil -f -importpfx $Path | ||
} | ||
} | ||
} | ||
else | ||
{ | ||
$CertificateLocation = Join-path $CertificateBaseLocation $Name | ||
Write-Verbose "Removing $CertificateLocation." | ||
dir $CertificateLocation | Remove-Item -Force -Confirm:$false | ||
Write-Verbose "Removing $name from $CertificateBaseLocation." | ||
gci $CertificateBaseLocation | ?{$_.Subject -match $name.Replace('*','')} | Remove-Item -Force -Confirm:$false | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is to support matching a wildcard certificate, such as *.mysite.com. |
||
} | ||
} | ||
|
||
|
@@ -110,36 +134,39 @@ function Test-TargetResource | |
[parameter()] | ||
[ValidateSet('Present','Absent')] | ||
[string] | ||
$Ensure = 'Present' | ||
$Ensure = 'Present', | ||
[parameter()] | ||
[string] | ||
$Password | ||
) | ||
|
||
$IsValid = $false | ||
|
||
$CertificateLocation = "cert:\$Location\$Store\$Name" | ||
$CertificateBaseLocation = "cert:\$Location\$Store\" | ||
|
||
if ($Ensure -like 'Present') | ||
{ | ||
Write-Verbose "Checking for $Name to be present in the $location store under $store." | ||
if (Test-Path $CertificateLocation) | ||
Write-Verbose "Checking for $Name to be present in the $CertificateBaseLocation store under $store." | ||
if (gci $CertificateBaseLocation | ?{$_.Subject -match $name.Replace('*','')}) | ||
{ | ||
Write-Verbose "Found a matching certficate at $CertificateLocation" | ||
Write-Verbose "Found a matching certficate at $CertificateBaseLocation" | ||
$IsValid = $true | ||
} | ||
else | ||
{ | ||
Write-Verbose "Unable to find a matching certficate at $CertificateLocation" | ||
Write-Verbose "Unable to find a matching certficate at $CertificateBaseLocation" | ||
} | ||
} | ||
else | ||
{ | ||
Write-Verbose "Checking for $Name to be absent in the $location store under $store." | ||
if (Test-Path $CertificateLocation) | ||
Write-Verbose "Checking for $Name to be absent in the $CertificateBaseLocation store under $store." | ||
if (gci $CertificateBaseLocation | ?{$_.Subject -match $name.Replace('*','')}) | ||
{ | ||
Write-Verbose "Found a matching certficate at $CertificateLocation" | ||
Write-Verbose "Found a matching certficate at $CertificateBaseLocation" | ||
} | ||
else | ||
{ | ||
Write-Verbose "Unable to find a matching certficate at $CertificateLocation" | ||
Write-Verbose "Unable to find a matching certficate at $CertificateBaseLocation" | ||
$IsValid = $true | ||
} | ||
} | ||
|
Binary file modified
BIN
+430 Bytes
(210%)
DSCResources/StackExchange_CertificateStore/StackExchange_CertificateStore.schema.mof
Binary file not shown.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CertUtil (Win2008) requires a clear text password, and Import-PFXCertificate requires a SecureString for password.
So the choice is to pass in a clear text password in $Password, then convert to SecureString. Or pass in a SecureString and decrypt to get the clear text.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Passing in a SecureString and decrypting the plain text if needed would be the better choice. (Though it looks like we'd actually be passing in a PSCredential, since that's what DSC will encrypt for you in the MOF document. It doesn't know what to do with SecureString objects passed by themselves.)