(SCHEMA) Update schemas for v3.1.0 release #890
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this change, the requirements for various resource kinds was incomplete and inaccurate. This change updates the `allOf` applicator to correctly define required and forbidden properties for each resource kind.
michaeltlombardi
force-pushed
the
schema/main/v3.1.0
branch
from
828ae59 to
bd559a5
Compare
SteveL-MSFT
reviewed
Jun 26, 2025
| $schema: https://json-schema.org/draft/2020-12/schema | ||
| $id: <HOST>/<PREFIX>/<VERSION>/extension/manifest.discover.yaml | ||
|
|
||
| title: Get Method |
There was a problem hiding this comment.
Shouldn't this be Discover Method?
SteveL-MSFT
requested changes
Jun 26, 2025
| manifests instead. | ||
| If initial discovery finds any extension manifests that have the `discover` capability, DSC uses | ||
| those extensions to recursively discover resources that aren't available in `PATH` or |
There was a problem hiding this comment.
I think you should remove the word recursively here
| $schema: https://json-schema.org/draft/2020-12/schema | ||
| $id: <HOST>/<PREFIX>/<VERSION>/extension/manifest.yaml | ||
|
|
||
| title: DSC resource manifest |
| emitted to stdout for the **Discover** operation to adhere to this schema. An extension indicates | ||
| that it supports the **Discover** operation by defining the [discover][01] field in its manifest. | ||
| The output must be a JSON object. |
There was a problem hiding this comment.
It may be worthwhile that if nothing is found, then emit nothing to STDOUT and have a 0 exit code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This changeset includes:
v3.0.1andv3.0.2releases. Neither of these releases required any schema changes except to extend the sets of valid schema URIs for resource manifests and configuration documents.v3.1.0release. This release required changes to support the addition of theexporterresource kind (and associated required output for the Export operation) and the addition of the extension manifest and expected output for the Discover extension operation.Until the changes for v3.1.0 are reviewed, I haven't regenerated the schemas to reduce the noise in the commits. After those changes are reviewed, I'll regenerate the schemas for v3.1.0.
PR Context