-
Notifications
You must be signed in to change notification settings - Fork 41
Surface _kind, _securityContext, and _name from resource during export #884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
dsc_lib/src/configure/config_doc.rs
Outdated
pub properties: Option<Map<String, Value>>, | ||
#[serde(skip_serializing_if = "Option::is_none")] | ||
pub metadata: Option<Map<String, Value>>, | ||
#[serde(rename = "securityContext", skip_serializing_if = "Option::is_none")] | ||
pub security_context: Option<String>, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
securityContext
is part of metadata already
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the goal to surface securityContext
in the resource metadata or the resource's Microsoft.DSC metadata (or somewhere else entirely)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be within the Microsoft.DSC
metadata where we have securityContext
already
What is |
The intent is to align with ARM where we have scenarios where this info is needed https://learn.microsoft.com/en-us/azure/azure-resource-manager/templates/syntax#resources. So short answer, is it's currently just a string with no validation. It isn't information that will be used by DSC itself, but higher level tools so scenario specific. I expect most DSC resources to not use this. |
PR Summary
export
to surface specific properties from resource at top-level, while also removing those properties from the lower-level objectPR Context