fix: make survey spacing consistent between visualizations #28562
+77
−80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR refactors spacing management in the survey visualization components by moving spacing responsibilities from individual components to the parent container.
- Added
space-y-4class to parent div in/frontend/src/scenes/surveys/SurveyView.tsxto handle consistent spacing between components - Removed individual margin classes (mb-4, mb-8) from visualization components in
/frontend/src/scenes/surveys/surveyViewViz.tsx - Removed unnecessary nested fragments and added proper div wrappers for NPS score display
- Simplified styling structure by centralizing spacing control without changing visual appearance
2 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
lucasheriques
commented
Feb 11, 2025
Comment on lines
+477
to
+483
| <div className="space-y-4"> | ||
| <Summary surveyUserStatsLoading={surveyUserStatsLoading} surveyUserStats={surveyUserStats} /> | ||
| {survey.questions.map((question, i) => { | ||
| if (question.type === SurveyQuestionType.Rating) { | ||
| return ( | ||
| <> | ||
| {question.scale === 10 && ( |
There was a problem hiding this comment.
high number of line changes is misleading here. I removed a fragment, so nesting shifted left, but the only change here is adding space-y-4 to the parent div
|
Size Change: 0 B Total Size: 1.18 MB ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
all components define space by themselves, which makes it harder to add new ones.
instead, move the spacing rule between each section to the parent component.
Changes
no functionality nor UI changes, it's just a code refactor
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Does this work well for both Cloud and self-hosted?
yes
How did you test this code?
checked if tests are still running as expected