fix(import-pipeline): dict and bytes mixup #28525
Merged
+26
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR addresses type conversion issues in the SQL database import pipeline, focusing on handling mixed data types in string columns.
- Added JSON serialization for dictionary values in string/bytes columns in
arrow_helpers.pyto prevent "Expected bytes, got a dict" errors - Changed default backend from 'sqlalchemy' to 'pyarrow' in
__init__.pyfor more stable schema handling - Added test case in
test_arrow_helpers.pyto verify proper dictionary serialization in string columns - Implemented type checking in
row_tuples_to_arrowto ensure consistent handling of mixed types - Modified column handling to properly serialize dict values while preserving other string/bytes data
3 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile
Comment on lines
124
to
129
| if issubclass(py_type, bytes) or issubclass(py_type, str): | ||
| # For bytes/str columns, ensure any dict values are serialized to JSON strings | ||
| columnar_known_types[field.name] = [ | ||
| None if x is None else json_dumps(x) if isinstance(x, dict) else x | ||
| for x in columnar_known_types[field.name] | ||
| ] |
There was a problem hiding this comment.
style: this serialization could potentially lose data if the dict contains types that can't be serialized to JSON. Consider adding a warning log similar to line 113 to alert users about the conversion.
posthog/temporal/data_imports/pipelines/sql_database/arrow_helpers.py
Outdated
Show resolved
Hide resolved
Gilbert09
approved these changes
Feb 11, 2025
…pers.py Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Changes
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Does this work well for both Cloud and self-hosted?
How did you test this code?