feat: Cross-sell Web Vitals to Product Analytics #28410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR adds cross-selling functionality between Web Vitals and Product Analytics by introducing a new "Open as new insight" button and standardizing URL handling across the application.
- Added new
WEB_VITALS_INSIGHTenum toProductIntentContextfor tracking cross-sell interactions - Modified
WebVitalscomponent to include "Open as new insight" button with proper intent tracking - Standardized URL generation across components by updating
urls.insightNew()to use object parameters instead of positional arguments - Renamed
insightTypeURLtoINSIGHT_TYPE_URLSconstant and updated imports across multiple components - Updated layout in
WebAnalyticsDashboardto accommodate new cross-selling functionality with proper feature flag controls
39 file(s) reviewed, 5 comment(s)
Edit PR Review Bot Settings | Greptile
frontend/src/scenes/data-management/properties/PropertyDefinitionsTable.tsx
Show resolved
Hide resolved
frontend/src/scenes/data-management/properties/PropertyDefinitionsTable.tsx
Show resolved
Hide resolved
|
Size Change: +49 B (0%) Total Size: 1.18 MB ℹ️ View Unchanged
|
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
robbie-c
approved these changes
Feb 7, 2025
By using an object we can more easily pass a query in - which happens very often
You can now go from Web Analytics to Product Analytics in Web Vitals, introducing another cross-selling opportunity. People can also set up Alerts from that page which is a nice addition!
The margin is wrong here after Tailwind changes, let's fix them
If the web vitals FF is disabled then this UI looked very wonky (currently online would display in the middle)
After the recent color changes this is looking bad, let's update it slightly
rafaeelaudibert
force-pushed
the
cross-sell-web-vitals-to-product-analytics
branch
from
3f3c62e to
38a7cac
Compare
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
rafaeelaudibert
deleted the
cross-sell-web-vitals-to-product-analytics
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Web Analytics has consistent "Open as new insight" buttons to allow you to go from Web Analytics to Product Analytics, but that wasn't a thing for Web Vitals.
Changes
Introduce a new button under the web vitals trend query to open it as a new insight. It'll copy the goal lines over to the Product Analytics page, but they aren't editable right now, this will come in a follow-up PR (or commit if this PR takes too long to be merged)
Does this work well for both Cloud and self-hosted?
Yes
How did you test this code?
Visually