chore: add new unsub options #28399
Merged
chore: add new unsub options #28399
+3
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zlwaterfield
commented
Feb 6, 2025
| @@ -329,8 +331,7 @@ export const billingProductLogic = kea<billingProductLogicType>([ | |||
| const reasonObject = UNSUBSCRIBE_REASONS.find((r) => r.reason === reason) | |||
| return reasonObject?.question | |||
| }) | |||
| .join(' ') | |||
| .concat(' (required)') | |||
| .join('\n') | |||
There was a problem hiding this comment.
Removed the required because it's obvious with the disabled submit and tool tip and looked odd with multiple answers selected.
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Added two new unsubscribe reasons to the billing system's survey options, expanding the feedback collection for customer churn analysis.
- Added 'Shutting down' option with follow-up question "We're sorry to hear that ❤️. What was your favorite feature?"
- Added 'Technical issues' option with follow-up question "What technical problems did you experience?"
- Modified
/frontend/src/scenes/billing/billingProductLogic.tsto join survey questions with newlines for better readability - Maintained randomization of options while keeping "Other" as the last choice
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
|
Size Change: -5 B (0%) Total Size: 1.18 MB ℹ️ View Unchanged
|
📸 UI snapshots have been updated4 snapshot changes in total. 0 added, 4 modified, 0 deleted:
Triggered by this commit. |
raquelmsmith
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Expanding the list of reasons for unsubscribing
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Does this work well for both Cloud and self-hosted?
It doesn't have an impact.
How did you test this code?