Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: attempting to fix toolbar #28398

Merged
merged 2 commits into from
Feb 6, 2025
Merged

fix: attempting to fix toolbar #28398

merged 2 commits into from
Feb 6, 2025

Conversation

adamleithp
Copy link
Contributor

Problem

Broke toolbar styles... :(

Changes

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

Does this work well for both Cloud and self-hosted?

How did you test this code?

@adamleithp adamleithp changed the title attempting to fix toolbar fix: attempting to fix toolbar Feb 6, 2025
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR addresses toolbar styling issues in PostHog by modifying the CSS import order and component isolation.

  • Modified CSS import order in /frontend/src/styles/base.scss to ensure proper style cascade with Tailwind components
  • Added :host selector for Shadow DOM compatibility in toolbar isolation
  • Added base styles import to /frontend/src/toolbar/bar/Toolbar.scss for consistent variable access
  • Fixed potential z-index layering issue between toolbar menu (z-index: 2) and main toolbar (z-index: 1)
  • Addressed toolbar theme compatibility by ensuring proper variable inheritance in light/dark modes

2 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile

frontend/src/styles/base.scss Outdated Show resolved Hide resolved
Copy link
Member

@pauldambra pauldambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't know if greptile is right about the order of imports
but this fixes the toolbar thing for me

Copy link
Contributor

github-actions bot commented Feb 6, 2025

Size Change: -5 B (0%)

Total Size: 1.18 MB

ℹ️ View Unchanged
Filename Size Change
frontend/dist/toolbar.js 1.18 MB -5 B (0%)

compressed-size-action

Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
@pauldambra pauldambra merged commit 2d39ad6 into master Feb 6, 2025
16 of 20 checks passed
@pauldambra pauldambra deleted the devex/fix-toolbar branch February 6, 2025 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants