feat(cdp): add ip anon transformation #28377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Added IP anonymization transformation to replace the last octet of IPv4 addresses with zero, enhancing user privacy in PostHog's CDP functionality.
- Added
ip-anonymization.template.tswith string splitting for efficient IPv4 anonymization (e.g., 192.168.1.1 → 192.168.1.0) - Implemented comprehensive test suite in
ip-anonymization.template.test.tscovering valid/invalid IPs and edge cases - Integrated template into
HOG_FUNCTION_TEMPLATES_TRANSFORMATIONSarray inindex.ts - Template marked as 'alpha' status with clear description and free availability
- Missing IPv6 support and potential edge case handling for malformed IP strings
3 file(s) reviewed, 4 comment(s)
Edit PR Review Bot Settings | Greptile
| } | ||
|
|
||
| let ip := event.properties.$ip | ||
| let parts := splitByString('.', ip) |
There was a problem hiding this comment.
logic: No validation of IP address octets. Values like '999.999.999.999' or 'a.b.c.d' will be processed as valid IPs if they contain 4 parts.
Suggested change
| let parts := splitByString('.', ip) | |
| let parts := splitByString('.', ip) | |
| // Validate each octet is a number between 0-255 | |
| if (length(parts) = 4 and all(x -> toInt(x) >= 0 and toInt(x) <= 255, parts)) { |
...server/src/cdp/templates/_transformations/ip-anonymization/ip-anonymization.template.test.ts
Show resolved
Hide resolved
Comment on lines
+20
to
+21
| let ip := event.properties.$ip | ||
| let parts := splitByString('.', ip) |
There was a problem hiding this comment.
style: Consider trimming the IP string to handle whitespace in input
...server/src/cdp/templates/_transformations/ip-anonymization/ip-anonymization.template.test.ts
Outdated
Show resolved
Hide resolved
benjackwhite
requested changes
Feb 6, 2025
plugin-server/src/cdp/templates/_transformations/ip-anonymization/ip-anonymization.template.ts
Outdated
Show resolved
Hide resolved
benjackwhite
approved these changes
Feb 6, 2025
…ion/ip-anonymization.template.test.ts Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We want to offer the same (or better) transformations as competitors.
IP anonymization transformation but uses string splitting instead of regex for performance.
Changes
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Does this work well for both Cloud and self-hosted?
How did you test this code?