fix: Custom day until now in Web Analytics #28360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR adds time precision support to the Web Analytics dashboard's date filter, allowing users to select specific hours and minutes when using the 'Custom date until now' option.
- Added
allowTimePrecision={true}prop toDateFiltercomponent in/frontend/src/scenes/web-analytics/WebAnalyticsDashboard.tsxto enable hour/minute selection - Fixes issue where custom date-to-now selections were defaulting to 12 AM regardless of selected time
- Leverages existing time precision functionality from the DateFilter component to properly apply selected times
💡 (1/5) You can manually trigger the bot by mentioning @greptileai in a comment!
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
cosmeoes
force-pushed
the
cosmeoes/fix-custom-date-until-now
branch
from
203c975 to
8724163
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Closes #28171
Changes
It now allows you to choose the time and applies the filter.
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Does this work well for both Cloud and self-hosted?
How did you test this code?