Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix mutation types in delete DAG #28110

Merged
merged 9 commits into from
Jan 30, 2025
+36 −9
Merged

fix: fix mutation types in delete DAG #28110

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
69ccf06
fix: fix mutation types in delete DAG
fuziontech Jan 30, 2025
616af97
undo AI changes
fuziontech Jan 30, 2025
9be653e
maybe a bit nicer api for waiting?
fuziontech Jan 30, 2025
5623d62
add a simpler map_all_hosts_in_shards func
fuziontech Jan 30, 2025
2ac9592
update docstring
fuziontech Jan 30, 2025
e193b11
docstring ticks
fuziontech Jan 30, 2025
ddf40f3
over my skis?
fuziontech Jan 30, 2025
dc8042c
add test for if shard exists
fuziontech Jan 30, 2025
2dcf02a
feedback and fixes
fuziontech Jan 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions dags/deletes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,16 +293,18 @@ def count_pending_deletes(client: Client) -> int:
@op
def wait_for_delete_mutations(
cluster: ResourceParam[ClickhouseCluster],
delete_person_events: tuple[PendingPersonEventDeletesTable, Mutation],
delete_person_events: tuple[PendingPersonEventDeletesTable, ShardMutations],
) -> PendingPersonEventDeletesTable:
pending_person_deletions, shard_mutations = delete_person_events

if not shard_mutations:
return pending_person_deletions

[table, mutations] = delete_person_events
cluster.map_all_hosts(mutations.wait).result()
return table
# Wait for all mutations across all shards
for mutation in shard_mutations.values():
cluster.map_all_hosts(mutation.wait).result()
fuziontech marked this conversation as resolved.
Show resolved Hide resolved

return pending_person_deletions


@op
Expand Down