feat: Improve path cleaning UI #27997
Open
+585
−179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@robbie-c In case you're wondering where I'm going with this, I need the capability to, when looking from the toolbar, see all of the events from that page after it's been aliased, so I need whatever I'm implementing in the following PR, this one is just cleaning this up and making the feature slightly more useful |
|
Size Change: +42 B (0%) Total Size: 1.16 MB ℹ️ View Unchanged
|
📸 UI snapshots have been updated4 snapshot changes in total. 0 added, 4 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
Ideally we'd want a smaller button, but people aren't familar with path cleaning yet, so let's make it slightly exaggerated
This is now much cleaner, and we also have a way to test what the path will look like once cleaned
Paths displayed on Web Analytics/Web Vitals table now properly render them using the new readable format for them, assuming people use the suggested `<slug>` format In a future PR we'll enable people to filter by cleaned paths, making cleaned paths much more powerful for WA/WV
rafaeelaudibert
force-pushed
the
path-cleaning-on-filters-for-web-analytics
branch
from
7ca5470 to
247bfc8
Compare
We're now allowing us to filter by cleaned path, which makes our UI slightly more powerful. If you select a cleaned path and `doPathCleaning` is set, we can see results from a specific cleaned path. The UX isn't great because it looks kinda wonky, and I'm pretending it's a `EXACT` match (which kinda is?) and you can't get into that state unless you click on a path in the UI, but it does work, so I think this is a win. Eventually once we have `$pathname` a high-level filter (rather than just another filter) we'll be able to make this behave better. Web Vitals is coming in the next commit
Now, if path cleaning is enabled and I filter by a path that would be cleaned, we display data from the filtered path instead
You can now click on a path on web vitals path breakdown to add it to the filter
We don't need to calculate that before hand, we can simply pass the metric to the function and it knows how to handle it
📸 UI snapshots have been updated4 snapshot changes in total. 0 added, 4 modified, 0 deleted:
Triggered by this commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Paths displayed on Web Analytics/Web Vitals table now properly render them using the new readable format for them, assuming people use the suggested
<slug>formatI've also made path cleaning a top-level filter on Web Analytics because I want to push people to use it to increase adoption. Once people have them set-up, the toolbar will be a no-brainer to explore Web Vitals
We've also changed how filtering works so that if someone has path cleaning enabled and clicks in one of the cleaned paths, we'll properly display results for that filter 🎉. To make things even, we've added this feature to Web Vitals as well.