Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hogql cohort queries #27811

Merged
merged 86 commits into from
Feb 20, 2025
Merged

fix: hogql cohort queries #27811

merged 86 commits into from
Feb 20, 2025

Conversation

aspicer
Copy link
Contributor

@aspicer aspicer commented Jan 23, 2025

Fixes some issues with hogql cohort queries and re-enables them for testing (with a feature flag by org)

  • Changes get_performed_event_multiple to a simple events query from a funnel
  • Fixes a bug with the return name of the "id" column being "person_id" in some queries
  • Removes the limit 100 accidentally imposed on queries by the LimitContext
  • Fixes property definition access for environments
  • Adds a feature flag based on org which lets us toggle these on and off

fix
@posthog-bot
Copy link
Contributor

Hey @aspicer! 👋
This pull request seems to contain no description. Please add useful context, rationale, and/or any other information that will help make sense of this change now and in the distant Mars-based future.

@posthog-bot
Copy link
Contributor

It looks like the code of hogql-parser has changed since last push, but its version stayed the same at 1.0.454. 👀
Make sure to resolve this in hogql_parser/setup.py before merging!

Copy link
Contributor

github-actions bot commented Jan 28, 2025

Size Change: 0 B

Total Size: 9.7 MB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 9.7 MB

compressed-size-action

aspicer and others added 13 commits January 28, 2025 16:11
…og into aspicer/cohort_hogql_fixes
…og into aspicer/cohort_hogql_fixes
…og into aspicer/cohort_hogql_fixes
aspicer and others added 26 commits February 5, 2025 11:54
…into aspicer/null_properties
…og into aspicer/cohort_hogql_fixes
hm
Copy link
Collaborator

@timgl timgl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

low context approval

@aspicer aspicer merged commit 0ead186 into master Feb 20, 2025
92 checks passed
@aspicer aspicer deleted the aspicer/cohort_hogql_fixes branch February 20, 2025 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants