Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Support different consumer / producer configs #27153

Draft
wants to merge 29 commits into
base: master
Choose a base branch
from

Conversation

benjackwhite
Copy link
Contributor

@benjackwhite benjackwhite commented Dec 25, 2024

Problem

We want to make migrating to a new kafka more straightfoward. Typically most of our services are consuming and then producing so if we want to migrate part-by-part what we really need is a way to specify a different producer to the consumer

Changes

  • Added some new config options and made it so that every config can specify a target (consumer vs producer)
  • Didn't do this for kafkajs as that is only used by consumers anyways (the default value)
  • Refactored the producer code so that it is all in one place
  • Added TODO for migrating replay to use this format (this can be our test bed on dev)

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

Does this work well for both Cloud and self-hosted?

How did you test this code?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant