Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unneeded horizontal scrolling on Onboarding pages #27134

Merged
merged 2 commits into from
Jan 2, 2025

Conversation

lucasheriques
Copy link
Contributor

Problem

Fixes #25527.

There's extra margin on the posthog onboarding pages that's causing an horizontal scroll.

Changes

Before Header
image CleanShot 2024-12-23 at 12 34 00@2x

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

Does this work well for both Cloud and self-hosted?

N/A

How did you test this code?

Verified on localhost, since it's a UI only change

@lucasheriques lucasheriques requested a review from a team December 23, 2024 15:35
@lucasheriques lucasheriques changed the title Fix unneeded horizontal scrolling on Onboarding pages fix: unneeded horizontal scrolling on Onboarding pages Dec 23, 2024
Copy link
Contributor

github-actions bot commented Dec 23, 2024

Size Change: 0 B

Total Size: 1.11 MB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 1.11 MB

compressed-size-action

@lucasheriques lucasheriques enabled auto-merge (squash) December 23, 2024 15:47
Copy link
Contributor

@zlwaterfield zlwaterfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think using a fixed value will resolve this.

We should probably be using the negative of --scene-padding which is the reason we need to have the negative margin in the first place and it's dependant on the screen size.

@lucasheriques
Copy link
Contributor Author

--scene-padding

ohh I didn't know we have that. yeah I just checked what was the padding on the scene and changed to the appropriate value.

thanks for the pointer!

@lucasheriques
Copy link
Contributor Author

@zlwaterfield added a new spacing size to use --scene-padding in the tailwind config

@posthog-bot
Copy link
Contributor

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week. If you want to permanentely keep it open, use the waiting label.

Copy link
Contributor

@zlwaterfield zlwaterfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay here, looks good!

@lucasheriques lucasheriques merged commit 926499c into master Jan 2, 2025
102 checks passed
@lucasheriques lucasheriques deleted the fix/onboarding-x-axis-overflow branch January 2, 2025 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Onboarding content causes x-axis overflow
4 participants