-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: unneeded horizontal scrolling on Onboarding pages #27134
Conversation
Size Change: 0 B Total Size: 1.11 MB ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think using a fixed value will resolve this.
We should probably be using the negative of --scene-padding
which is the reason we need to have the negative margin in the first place and it's dependant on the screen size.
ohh I didn't know we have that. yeah I just checked what was the padding on the scene and changed to the appropriate value. thanks for the pointer! |
@zlwaterfield added a new spacing size to use |
This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay here, looks good!
Problem
Fixes #25527.
There's extra margin on the posthog onboarding pages that's causing an horizontal scroll.
Changes
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Does this work well for both Cloud and self-hosted?
N/A
How did you test this code?
Verified on localhost, since it's a UI only change