Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(replay): allow triggering session recording based on urls #25451

Merged
merged 37 commits into from
Oct 17, 2024
Merged
Changes from 1 commit
Commits
Show all changes
37 commits
Select commit Hold shift + click to select a range
5fe4a5f
add new property for url triggers
Oct 8, 2024
6299abd
refactor: rename logic file to be more generic
Oct 8, 2024
144ced4
refactor: remove feature flag id from props, read from team logic
Oct 8, 2024
57ee738
add ui and logic to add/update/edit/show triggers
Oct 9, 2024
37547f6
add migration
Oct 9, 2024
28d6248
whitespace
Oct 9, 2024
68f6e75
reformat
Oct 9, 2024
dfc2aeb
Update query snapshots
github-actions[bot] Oct 9, 2024
39bc84d
Update query snapshots
github-actions[bot] Oct 9, 2024
e373715
Update UI snapshots for `chromium` (1)
github-actions[bot] Oct 9, 2024
1bc369a
Update query snapshots
github-actions[bot] Oct 9, 2024
3694b17
Update UI snapshots for `chromium` (1)
github-actions[bot] Oct 9, 2024
d852322
fix for migration warning
Oct 9, 2024
f931436
fix missing property on tests
Oct 9, 2024
2d140be
format
Oct 9, 2024
cb737c7
add basic activity description
Oct 9, 2024
de18c12
add test
Oct 9, 2024
8f67fba
align property name with sdk
Oct 9, 2024
024689e
format
Oct 14, 2024
e6274cc
format
Oct 14, 2024
73a91e2
Merge branch 'master' into richard/url-trigger
Oct 14, 2024
75d6f04
update migrations
Oct 14, 2024
c7f3471
fix test, also opt in to session replay
Oct 17, 2024
16f5f52
Merge branch 'master' into richard/url-trigger
Oct 17, 2024
91bcd4a
update migration
Oct 17, 2024
eb444b9
spacing, add helper text
Oct 17, 2024
b1928d3
Update UI snapshots for `chromium` (1)
github-actions[bot] Oct 17, 2024
c34ed96
hide it behind a feature flag for now
Oct 17, 2024
19e5524
make spacing smaller
Oct 17, 2024
b118452
Update UI snapshots for `chromium` (1)
github-actions[bot] Oct 17, 2024
b7dccdc
Update UI snapshots for `chromium` (1)
github-actions[bot] Oct 17, 2024
151f668
Update UI snapshots for `chromium` (1)
github-actions[bot] Oct 17, 2024
1def1cb
Update `_update_team`
Twixes Oct 17, 2024
05b9423
Merge branch 'master' into richard/url-trigger
Oct 17, 2024
b99c70d
update migrations
Oct 17, 2024
2731c8b
Update query snapshots
github-actions[bot] Oct 17, 2024
5428649
Update UI snapshots for `chromium` (1)
github-actions[bot] Oct 17, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update query snapshots
github-actions[bot] committed Oct 9, 2024

Unverified

No user is associated with the committer email.
commit 1bc369af26d8e6cc51bd663bc96eb7b5d4dd5589
5 changes: 5 additions & 0 deletions posthog/models/filters/test/__snapshots__/test_filter.ambr
Original file line number Diff line number Diff line change
@@ -25,6 +25,7 @@
"posthog_team"."session_recording_minimum_duration_milliseconds",
"posthog_team"."session_recording_linked_flag",
"posthog_team"."session_recording_network_payload_capture_config",
"posthog_team"."session_recording_url_trigger_config",
"posthog_team"."session_replay_config",
"posthog_team"."capture_console_log_opt_in",
"posthog_team"."capture_performance_opt_in",
@@ -89,6 +90,7 @@
"posthog_team"."session_recording_minimum_duration_milliseconds",
"posthog_team"."session_recording_linked_flag",
"posthog_team"."session_recording_network_payload_capture_config",
"posthog_team"."session_recording_url_trigger_config",
"posthog_team"."session_replay_config",
"posthog_team"."capture_console_log_opt_in",
"posthog_team"."capture_performance_opt_in",
@@ -153,6 +155,7 @@
"posthog_team"."session_recording_minimum_duration_milliseconds",
"posthog_team"."session_recording_linked_flag",
"posthog_team"."session_recording_network_payload_capture_config",
"posthog_team"."session_recording_url_trigger_config",
"posthog_team"."session_replay_config",
"posthog_team"."capture_console_log_opt_in",
"posthog_team"."capture_performance_opt_in",
@@ -217,6 +220,7 @@
"posthog_team"."session_recording_minimum_duration_milliseconds",
"posthog_team"."session_recording_linked_flag",
"posthog_team"."session_recording_network_payload_capture_config",
"posthog_team"."session_recording_url_trigger_config",
"posthog_team"."session_replay_config",
"posthog_team"."capture_console_log_opt_in",
"posthog_team"."capture_performance_opt_in",
@@ -281,6 +285,7 @@
"posthog_team"."session_recording_minimum_duration_milliseconds",
"posthog_team"."session_recording_linked_flag",
"posthog_team"."session_recording_network_payload_capture_config",
"posthog_team"."session_recording_url_trigger_config",
"posthog_team"."session_replay_config",
"posthog_team"."capture_console_log_opt_in",
"posthog_team"."capture_performance_opt_in",

Unchanged files with check annotations Beta

v8Profiler.setSamplingInterval(interval ?? 1000) // in microseconds
v8Profiler.startProfiling('cpu', true, mode)
finishProfile = () => v8Profiler.stopProfiling('cpu')
case 'heap':

Check warning on line 124 in plugin-server/src/main/services/http-server.ts

GitHub Actions / Code quality

Expected a 'break' statement before 'case'
// See https://v8docs.nodesource.com/node-18.16/d7/d76/classv8_1_1_heap_profiler.html
const depth = typeof req.query.depth === 'string' ? parseInt(req.query.depth) : 16
v8Profiler.startSamplingHeapProfiling(interval ?? 512 * 1024, depth)
import { ActivityScope, TeamType } from '~/types'
const teamActionsMapping: Record<

Check failure on line 18 in frontend/src/scenes/teamActivityDescriber.tsx

GitHub Actions / Code quality checks

Property 'session_recording_url_trigger_config' is missing in type '{ session_recording_minimum_duration_milliseconds: (change: ActivityChange | undefined) => { description: Element[]; } | null; capture_console_log_opt_in(change: ActivityChange | undefined): ChangeMapping | null; ... 46 more ...; live_events_token: () => null; }' but required in type 'Record<keyof TeamType, (change?: ActivityChange | undefined, logItem?: ActivityLogItem | undefined) => ChangeMapping | null>'.
keyof TeamType,
(change?: ActivityChange, logItem?: ActivityLogItem) => ChangeMapping | null
> = {