feat(web-analytics): Fix the query limit not being increased for external clicks / web goals when opened as a modal #25086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ls when opened as a modal
robbie-c
changed the title
|
Size Change: 0 B Total Size: 1.1 MB ℹ️ View Unchanged
|
daibhin
approved these changes
Sep 19, 2024
robbie-c
deleted the
fix/fix-limit-not-being-increased-for-external-clicks-in-modal
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The limit stays at 10 when opening the external clicks query or the web goals query as a model. It should increase to 50
Changes
Fix the logic so the limit is increased correctly.
Does this work well for both Cloud and self-hosted?
Yes
How did you test this code?
Ran it locally, opened the modal