Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cdp): remove duplicate global fields #25081

Merged
merged 5 commits into from
Sep 20, 2024
Merged

Conversation

mariusandra
Copy link
Collaborator

@mariusandra mariusandra commented Sep 19, 2024

Problem

We have a few duplicate fields in the CDP/Hog globals, e.g. person.id and person.uuid.

Changes

  • Removes the duplicates, preferring the same names as used in the database.
  • Should only be merged after we make sure all existing functions do not use the new names.

How did you test this code?

Changed all functions in production to not use the removed fields. Made all the tests pass.

Copy link
Contributor

github-actions bot commented Sep 19, 2024

Size Change: +28 B (0%)

Total Size: 1.1 MB

ℹ️ View Unchanged
Filename Size Change
frontend/dist/toolbar.js 1.1 MB +28 B (0%)

compressed-size-action

@mariusandra
Copy link
Collaborator Author

I manually removed all instances of event.name and person.uuid from all the function on both EU and US clouds. This should be ready to review and merge.

@mariusandra mariusandra requested review from benjackwhite and a team September 20, 2024 07:33
@mariusandra mariusandra merged commit 5098048 into master Sep 20, 2024
95 checks passed
@mariusandra mariusandra deleted the remove-duplicate-fields branch September 20, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants