fix(events): auto load new events checkbox issue

[abhi12299]

Problem

• When the Automatically load new events checkbox is unchecked and the user cancels the ongoing query, the error message displayed is "The query was cancelled" - which is correct.
  However, after this, when the checkbox is checked, the error is about AbortSignal and it does not trigger a refetch immediately.

• When you cancel the ongoing query when the Automatically load new events checkbox is checked, you will see the AbortSignal error.

Here's the bug:

bug-autoload.mov

Changes

• loadNewData prioritises new response if the existing response is null.

  posthog/frontend/src/queries/nodes/DataNode/dataNodeLogic.ts

  Lines 238 to 264 in dfbd23b

  	loadNewData: async () => {
  	if (props.cachedResults) {
  	return props.cachedResults
  	}
  	if (!values.canLoadNewData || values.dataLoading) {
  	return values.response
  	}
  	if (isEventsQuery(props.query) && values.newQuery) {
  	const now = performance.now()
  	const newResponse =
  	(await performQuery(
  	addModifiers(values.newQuery, props.modifiers),
  	undefined,
  	props.alwaysRefresh
  	)) ?? null
  	actions.setElapsedTime(performance.now() - now)
  	if (newResponse?.results) {
  	actions.highlightRows(newResponse?.results)
  	}
  	const currentResults = ((values.response || { results: [] }) as EventsQueryResponse).results
  	return {
  	...values.response,
  	results: [...(newResponse?.results ?? []), ...currentResults],
  	}
  	}
  	return values.response

  
  Lines 258-262 here show that the object returned from the loader will only have results key if values.response is null

• responseError reducer also reacts to loadNewData... actions; this helps to get rid of the error state when new data is loaded.

• When you cancel the ongoing query when the Automatically load new events checkbox is checked, you will not see any error state in the table - this is because the auto load functionality will trigger a refetch in 30s anyways, so it is not a good UX to show an error state only for it to be replaced with the table after 30s.

Here's the fix:

fix.mov

[abhi12299]

Will fix the cypress tests after discussing and finalising on the desired behaviour.

[Twixes]

Looks good to me @abhi12299! But not sure why CI's red, definitely worth getting to green

[abhi12299]

@Twixes working on it!

[abhi12299]

@Twixes only the visual regression tests fail. I don't think I have access to the artifacts uploaded by the tests to see what the difference is.

[Twixes]

Looks good, thank you!

[posthog-bot]

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week. If you want to permanentely keep it open, use the waiting label.