feat(environments): Environment settings, behind flag #25000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Twixes
force-pushed
the
switchable-environments
branch
from
dd0b6f6
to
781ae1a
Compare
|
Size Change: +2.07 kB (+0.19%) Total Size: 1.11 MB
|
Twixes
force-pushed
the
switchable-environments
branch
from
781ae1a
to
2534fd1
Compare
|
I took a look - this all looks impressive at a glance, other than a lot of the tests are failing. Happy to look again and check it after that! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This is step 10 of the environments project – #13418 (comment). (They are not necessarily sequential.)
Mostly just moving things around (what was called "ProjectFoo" in code is now "TeamFoo" for clarity), and then a few additions:
projectLogic.ts,ProjectDangerZone.tsx,ProjectDetails.tsx, and a new flag calledenvironments.All these changes feed into the updated
SettingsMap.tsx/settingsLogic.ts/settingsSceneLogic.ts. Tere should be no difference AT ALL to users with theenvironmentsflag off – but when the flag is on, settings fully reflect the new hierarchy: