Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(insights): truncated charts in firefox #24990

Merged
merged 6 commits into from
Oct 11, 2024

Conversation

abhi12299
Copy link
Contributor

@abhi12299 abhi12299 commented Sep 16, 2024

Fixes #24868

fix.mov

Note: the height property that is removed in this PR has no effect visual side effects on the .StepLegend contrary to the comment in the same file.

@abhi12299
Copy link
Contributor Author

how do i view the artifacts uploaded by the Visual regression tests workflow? It seems to be failing but I don't have access to the uploaded artifacts i think.

@Twixes Twixes self-requested a review September 17, 2024 12:34
Copy link
Collaborator

@Twixes Twixes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, the 1px hack was necessary a couple years ago, but now .StepLegend's height: 100% does seem to work without it. Let's get this in. Thanks!

@Twixes Twixes enabled auto-merge (squash) September 23, 2024 13:51
@posthog-bot
Copy link
Contributor

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week. If you want to permanentely keep it open, use the waiting label.

@posthog-bot posthog-bot removed the stale label Oct 3, 2024
@posthog-bot
Copy link
Contributor

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week. If you want to permanentely keep it open, use the waiting label.

@Twixes Twixes merged commit 6d0dc46 into PostHog:master Oct 11, 2024
92 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Frontend: Charts are truncated in firefox in certain scroll conditions
3 participants