add canvas config instructions #10591
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Hey there! In Typescript, the SessionRecordingCanvasOptions type tells that 'canvasQuality' is a string. May this needs to be respected. type SessionRecordingCanvasOptions = {
recordCanvas?: boolean | null;
canvasFps?: number | null;
canvasQuality?: string | null;
}; |
|
Had a quick look onto it. Maybe there is an issue on the typescript interface itself! Here the session recording is using the canvasQuality as number: |
|
No, that's a good catch @mxzinke. It comes out of the backend as a string... but we use it as a number... it (will|must) always be a valid decimal |
|
Alright. But than still may the documentation needs to be updated on the posthog-js. The defaults aren't matching with your documentation here. Sorry for being so picky... |
| session_recording: { | ||
| captureCanvas: { | ||
| // accepts a number between 0 and 12 | ||
| // if not set locally, when canvas recording is enabled, remote config sets this to 4 |
There was a problem hiding this comment.
it's best to comment on lines or files @mxzinke cos then we can thread :)
literally the worst UX feature of GitHub, that you can't thread on the conversation tab
default was a poor choice of words maybe... if you turn on canvas recoding, the backend provides a fixed value. to change it you have to override in config
There was a problem hiding this comment.
There was a problem hiding this comment.
Thanks for clarifying. Now way more understandable.
It would be awesome if the docs on types on posthog-js repo would also have this information :)
Co-authored-by: Ian Vanagas <[email protected]>
Co-authored-by: Ian Vanagas <[email protected]>
i've manually recreated this a couple of times in support... adding to docs to save the future traveller