-
Notifications
You must be signed in to change notification settings - Fork 478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Product index page (v1) #10221
Merged
Merged
Product index page (v1) #10221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until now, the Products nav link has defaulted visitors into our first product, Product analytics. Since our product list is growing, it's worth having an index page where visitors can browse all the products, filter them, and browse them by use case or stage of company.
Here's the v1:
Todos
Adjust the content layout width
Without being in wide mode, the listing blocks aren't wide enough, causing content to wrap needlessly. We should adjust the
max-width
in non-wide mode (for this page only) frommax-w-3xl
tomax-w-4xl
.Stretch: Support the left sidebar (or a "lite" version of it) as seen below
Longer-term...
In #10222, I'm outlining some other changes we'll need to make to support a much larger volume of products. Part of this includes adding tags so we can cut products in other ways, like role, goal, or product type. See the left sidebar (and updated submenu) in this wire: