-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: check for stylesheets on current domain too #9
Merged
+12
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Change: +5.23 kB (+0.05%) Total Size: 10.3 MB
ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
first added in PostHog/posthog-js#1272 and PostHog/posthog-js#1275
with original PR description there
Problem
Relates to https://posthoghelp.zendesk.com/agent/tickets/14512 (and probably a bunch more support tickets)
This could also be related to rrweb-io/rrweb#1230
Addresses an issue in recordings where styles were being dropped during some route changes in SPAs
Reproduction
It's not fully clear to me how this happens or what the correct behaviour is but the problem exists when:
This gets loaded into the documents
styleSheets
array with the href set ashttps://domainname.com/_app/immutable/assets/filename.css
Sometime later the domain changes away from the index page to another root e.g.
https://domainname.com/home
When taking the next full snapshot rrweb tries to fetch the stylesheet associated with the href:
n.href
now evaluates tohttps://domainname.com/home/_app/immutable/assets/filename.css
which no longer matches thehref
of the stylesheet on the document and hence cannot be "found". Presumably the href on the document stylesheet does not change because the SPA is not doing a full page transitionChanges
This PR adds a backup check to look for the CSS on the root of the domain
This feels like the safest change for now but will get the opinion of others in the rrweb community too