Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Tidying and removing of old value #941

Merged
merged 1 commit into from
Dec 19, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 4 additions & 9 deletions src/posthog-persistence.ts
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@ export class PostHogPersistence {
expire_days: number | undefined
default_expiry: number | undefined
cross_subdomain: boolean | undefined
user_state: 'anonymous' | 'identified'

constructor(config: PostHogConfig) {
// clean chars that aren't accepted by the http spec for cookie values
Expand Down Expand Up @@ -81,17 +80,13 @@ export class PostHogPersistence {
this.storage = memoryStore
} else if (storage_type === 'cookie') {
this.storage = cookieStore
} else {
} else if (localPlusCookieStore.is_supported()) {
// selected storage type wasn't supported, fallback to 'localstorage+cookie' if possible
if (localPlusCookieStore.is_supported()) {
this.storage = localPlusCookieStore
} else {
this.storage = cookieStore
}
this.storage = localPlusCookieStore
} else {
this.storage = cookieStore
}

this.user_state = 'anonymous'

this.load()
this.update_config(config)
this.save()
Expand Down
Loading