feat(surveys): make link survey link optional #938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 752 kB ℹ️ View Unchanged
|
| @@ -587,8 +587,8 @@ export const createOpenTextOrLinkPopup = ( | |||
| [`$survey_responded/${survey.id}`]: true, | |||
| }, | |||
| }) | |||
| if (surveyQuestionType === 'link') { | |||
| window.open(question.link || undefined) | |||
There was a problem hiding this comment.
Curious, why did we do it like this previously? window.open(undefined) opens an empty tab.
There was a problem hiding this comment.
we originally required link urls for link type surveys so the button was always going to open something one way or another 😅
I think window.open("") would open something weird so passing in undefined was better
There was a problem hiding this comment.
What does the CTA do now, if it doesn't link to something? 🤔
jurajmajerik
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
PostHog/posthog#19320
Link is now optional for link type surveys
Checklist