fix: sanitize class string more #925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tiina303 since this touches an area you're actively working on. I tried to keep a minimal change so hopefully I can fix the issue in PostHog/posthog#19068 without clashing with your work |
|
Size Change: +460 B (0%) Total Size: 745 kB
ℹ️ View Unchanged
|
daibhin
approved these changes
Dec 7, 2023
tiina303
approved these changes
Dec 7, 2023
davemurphysf
reviewed
Dec 7, 2023
src/__tests__/autocapture.test.ts
Outdated
| it('returns elementsChain correctly with newlines in css', () => { | ||
| const elTarget = document.createElement('a') | ||
| elTarget.setAttribute('href', 'http://test.com') | ||
| elTarget.setAttribute('class', 'test-class\n test-class2 test-class3 test-class4 \r\n test-class5') |
There was a problem hiding this comment.
Can you add \t and \f characters in here, just for completeness sake?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are very intolerant of class strings that contain multiple spaces, tabs, or new lines when processing autocapture.
Technically the class attribute should always be a space separated set of strings, but computers let you generate all kinds of HTML 🙈
Follow-up to #919
This sanitizes the class string in more places so that we generate a working elements chain string even with an invalid css class.