Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add wbraid and gbraid to campaignParams #923

Merged
merged 1 commit into from
Dec 6, 2023

Conversation

mbifulco
Copy link
Contributor

@mbifulco mbifulco commented Dec 6, 2023

Changes

This adds gbraid and wbraid to campaign parameters captured from the URLs and stored as a property on the user, similar to #277.

For more context, these are new tracking Ids being used by google as the result of recent legislation changes. More here

We need this to track conversion from google ad clicks.
...

Checklist

@camerondeleone
Copy link

looks good 🚢 - addresses #922

Copy link

@camerondeleone camerondeleone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mbifulco mbifulco changed the title Add wbraid and gbraid to campaignParams feat: Add wbraid and gbraid to campaignParams Dec 6, 2023
@benjackwhite benjackwhite added the bump patch Bump patch version when this PR gets merged label Dec 6, 2023
Copy link
Collaborator

@benjackwhite benjackwhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! Assuming tests pass, I'll get this merged 👍

@benjackwhite
Copy link
Collaborator

Going ahead and merging - the testcafe tests dont run for external contrib but there's no way this change would break them (famous last words...)

@benjackwhite benjackwhite merged commit 00b0a2e into PostHog:master Dec 6, 2023
9 of 13 checks passed
@mbifulco mbifulco deleted the feat/wbraid-gbraid branch December 6, 2023 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump patch Bump patch version when this PR gets merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants