Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: safer toolbar function #1637

Merged
merged 1 commit into from
Jan 3, 2025
Merged

fix: safer toolbar function #1637

merged 1 commit into from
Jan 3, 2025

Conversation

pauldambra
Copy link
Member

see https://us.posthog.com/project/2/error_tracking/295441fc-c916-4257-a1cb-4d896601ad82 and https://bsky.app/profile/victornido.bsky.social/post/3leti5mx6q22j

getting (de.ph_load_toolbar || de.ph_load_editor) is not a function error

it's not clear why to me, but we can at least make it fail gracefully

Copy link

vercel bot commented Jan 3, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
posthog-js ✅ Ready (Inspect) Visit Preview Jan 3, 2025 11:42am

Copy link

github-actions bot commented Jan 3, 2025

Size Change: +800 B (+0.02%)

Total Size: 3.22 MB

Filename Size Change
dist/array.full.es5.js 262 kB +81 B (+0.03%)
dist/array.full.js 365 kB +81 B (+0.02%)
dist/array.full.no-external.js 364 kB +81 B (+0.02%)
dist/array.js 179 kB +79 B (+0.04%)
dist/array.no-external.js 178 kB +79 B (+0.04%)
dist/main.js 180 kB +79 B (+0.04%)
dist/module.full.js 365 kB +81 B (+0.02%)
dist/module.full.no-external.js 364 kB +81 B (+0.02%)
dist/module.js 179 kB +79 B (+0.04%)
dist/module.no-external.js 178 kB +79 B (+0.04%)
ℹ️ View Unchanged
Filename Size
dist/all-external-dependencies.js 206 kB
dist/customizations.full.js 12.6 kB
dist/dead-clicks-autocapture.js 14.4 kB
dist/exception-autocapture.js 9.48 kB
dist/external-scripts-loader.js 2.64 kB
dist/recorder-v2.js 115 kB
dist/recorder.js 115 kB
dist/surveys-preview.js 57.6 kB
dist/surveys.js 63.3 kB
dist/tracing-headers.js 1.76 kB
dist/web-vitals.js 10.4 kB

compressed-size-action

@pauldambra pauldambra merged commit cc48c9d into main Jan 3, 2025
30 checks passed
@pauldambra pauldambra deleted the fix/safer-toolbar-fn branch January 3, 2025 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants