Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not even send heatmap with no x or y #1621

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

pauldambra
Copy link
Member

@pauldambra pauldambra commented Dec 19, 2024

#1620 reminds us that JS can and will let people do whatever they want so we can't be guaranteed that events that trigger event listeners are really valid events

this filters out any event that doesn't have the clientX and clientY that we rely on

we safely filter these in ingestion, but we may as well just not send them

Copy link

vercel bot commented Dec 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
posthog-js ✅ Ready (Inspect) Visit Preview Dec 19, 2024 1:14pm

Copy link

Size Change: +1.01 kB (+0.03%)

Total Size: 3.22 MB

Filename Size Change
dist/array.full.es5.js 262 kB +103 B (+0.04%)
dist/array.full.js 365 kB +103 B (+0.03%)
dist/array.full.no-external.js 364 kB +103 B (+0.03%)
dist/array.js 179 kB +100 B (+0.06%)
dist/array.no-external.js 178 kB +100 B (+0.06%)
dist/main.js 180 kB +100 B (+0.06%)
dist/module.full.js 365 kB +103 B (+0.03%)
dist/module.full.no-external.js 364 kB +103 B (+0.03%)
dist/module.js 179 kB +100 B (+0.06%)
dist/module.no-external.js 178 kB +100 B (+0.06%)
ℹ️ View Unchanged
Filename Size
dist/all-external-dependencies.js 206 kB
dist/customizations.full.js 12.6 kB
dist/dead-clicks-autocapture.js 14.4 kB
dist/exception-autocapture.js 9.48 kB
dist/external-scripts-loader.js 2.48 kB
dist/recorder-v2.js 115 kB
dist/recorder.js 115 kB
dist/surveys-preview.js 57.6 kB
dist/surveys.js 63.3 kB
dist/tracing-headers.js 1.76 kB
dist/web-vitals.js 10.4 kB

compressed-size-action

@pauldambra pauldambra added the bump patch Bump patch version when this PR gets merged label Dec 19, 2024
@pauldambra pauldambra merged commit 68f00fc into main Dec 19, 2024
16 checks passed
@pauldambra pauldambra deleted the fix/pd-do-not-even-send-heatmap-with-no-x-y branch December 19, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump patch Bump patch version when this PR gets merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants