fix: endless capturing /s/ #1551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Size Change: +1.38 kB (+0.04%) Total Size: 3.14 MB
ℹ️ View Unchanged
|
pauldambra
commented
Nov 26, 2024
pauldambra
commented
Nov 26, 2024
daibhin
approved these changes
Nov 26, 2024
marandaneto
reviewed
Nov 26, 2024
| const ignorePostHogPaths = (data: CapturedNetworkRequest): CapturedNetworkRequest | undefined => { | ||
| const ignorePostHogPaths = ( | ||
| data: CapturedNetworkRequest, | ||
| apiHostConfig: PostHogConfig['api_host'] |
There was a problem hiding this comment.
do we need to filter from ui_host as well?
There was a problem hiding this comment.
I don't think so... I think it's just the possible endless loop of capturing our own api calls with our own api calls 🤞
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We check for
/s/,/e/, and/i/in URL's pathname and don't capture network payloads to themBut if you use a reverse proxy then the pathname won't necessarily be
/s/e.g. some folk use/ingest/s/so we need a slightly different checkOtherwise when you visit one of these sites we endlessly send a network payload to ourselves recording that we just sent a network payload to ourselves etc