Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refactor some cypress setup #1467

Merged
merged 4 commits into from
Oct 14, 2024
Merged

Conversation

pauldambra
Copy link
Member

It always bothered me when I copy-pastied a new script into the cypress setup

well, no more

Copy link

vercel bot commented Oct 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
posthog-js ✅ Ready (Inspect) Visit Preview Oct 14, 2024 4:36pm

@@ -24,7 +24,7 @@ export const start = ({
// sometimes we have too many listeners in this test environment
// that breaks the event emitter listeners in error tracking tests
// we don't see the error in production, so it's fine to increase the limit here
EventEmitter.prototype._maxListeners = 100
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is equivalent but one is less naughty

@pauldambra pauldambra requested a review from a team October 14, 2024 16:12
Copy link

github-actions bot commented Oct 14, 2024

Size Change: 0 B

Total Size: 2.82 MB

ℹ️ View Unchanged
Filename Size
dist/all-external-dependencies.js 191 kB
dist/array.full.js 353 kB
dist/array.full.no-external.js 352 kB
dist/array.js 168 kB
dist/array.no-external.js 167 kB
dist/exception-autocapture.js 10.5 kB
dist/external-scripts-loader.js 2.35 kB
dist/main.js 169 kB
dist/module.full.js 353 kB
dist/module.full.no-external.js 352 kB
dist/module.js 168 kB
dist/module.no-external.js 167 kB
dist/recorder-v2.js 111 kB
dist/recorder.js 111 kB
dist/surveys-preview.js 59.8 kB
dist/surveys.js 66 kB
dist/tracing-headers.js 8.36 kB
dist/web-vitals.js 10.3 kB

compressed-size-action

Copy link
Contributor

@Phanatic Phanatic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants