fix(errors): Build endpoint for sentry integration & exception observer correctly #1390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
neilkakkar
commented
Aug 28, 2024
|
|
||
| it('sends event to the correct endpoint', () => { | ||
| const error = new Error('test error') | ||
| window!.onerror?.call(window, 'message', 'source', 0, 0, error) |
There was a problem hiding this comment.
not working locally, all these tests, checking if they do on CI 👀
There was a problem hiding this comment.
node version 18.XX was the culprit, had to upgrade to 18.20
|
Size Change: +424 B (+0.04%) Total Size: 1.17 MB
ℹ️ View Unchanged
|
daibhin
approved these changes
Aug 28, 2024
This was referenced Sep 24, 2024
This was referenced Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixes #1389
I'm not sure how best to add tests for the sentry integration, any prior stuff here?
...
Checklist