-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Move chrome tests off of browserstack, add firefox #1369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Size Change: 0 B Total Size: 1.17 MB ℹ️ View Unchanged
|
robbie-c
changed the title
chore: Move chrome tests off of browserstack
chore: Move chrome tests off of browserstack, add firefox
Aug 20, 2024
pauldambra
approved these changes
Aug 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🦾 love it
(can make the firefox job required after this too?)
I don't have powers to do that but if you do then please go ahead :) |
ugh, i don't any more :/ |
Phanatic
pushed a commit
that referenced
this pull request
Aug 20, 2024
* Move chrome tests off of browserstack * Fix * Fix * Add firefox * Fix
This was referenced Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
We can run chrome on the actions runner without needing to use browserstack. This means that we only use 2 of our 5 browserstack concurrent tests per PR rather than 3, which lets us have 2 PRs running tests in parallel.
I also added headless firefox because why not.
Checklist