feat(surveys): add support for a 7 point likert scale #1319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Size Change: +303 B (+0.03%) Total Size: 1.16 MB
ℹ️ View Unchanged
|
Phanatic
approved these changes
Jul 24, 2024
| @@ -158,7 +158,14 @@ export function RatingQuestion({ | |||
| className="rating-options-number" | |||
| style={{ gridTemplateColumns: `repeat(${scale - starting + 1}, minmax(0, 1fr))` }} | |||
| > | |||
| {(question.scale === 5 ? fiveScaleNumbers : tenScaleNumbers).map((number, idx) => { | |||
| {(question.scale === 5 | |||
There was a problem hiding this comment.
Maybe we should break this out into a variable. Its pretty confusing to read nested ternary statements here.
This was referenced Aug 16, 2024
This was referenced Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
New survey behavior
No backend changes needed, the response is just a number under the hood. Just needed some UI love to support this.
Closes PostHog/posthog#23922
Ships with associated PostHog app changes here: PostHog/posthog#23956