fix: Fix the referrer changing mid-session #1314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
robbie-c
commented
Jul 22, 2024
| posthog.capture(eventName, eventProperties) | ||
| } | ||
| expect(onCapture).toHaveBeenCalledTimes(1) | ||
| expect(onCapture.mock.calls[0][0]).toBe('$$client_ingestion_warning') |
There was a problem hiding this comment.
This test was broken before, it relied on state from the previous test and failed when run in isolation.
robbie-c
commented
Jul 22, 2024
| expect(properties['$referring_domain']).toBe('referrer.example.com') | ||
| }) | ||
|
|
||
| it('should not update the referrer within the same session', () => { |
There was a problem hiding this comment.
This test fails without the fix in this PR
robbie-c
commented
Jul 22, 2024
| @@ -227,7 +227,7 @@ export class PostHogPersistence { | |||
| } | |||
|
|
|||
| update_referrer_info(): void { | |||
| this.register(Info.referrerInfo()) | |||
| this.register_once(Info.referrerInfo(), undefined) | |||
There was a problem hiding this comment.
The one-line actual fix
|
Size Change: +48 B (0%) Total Size: 1.19 MB
ℹ️ View Unchanged
|
benjackwhite
approved these changes
Jul 23, 2024
This was referenced Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
As part of the personless event changes, we accidentally introduced a bug where the referrer could change mid-session. This shouldn't happen, and led to some annoying situation where e.g. if a payments workflow navigated people to checkout.stripe.com and then back to the original site, the referrer would switch to stripe, which meant that any events after that couldn't be attributed to the original referrer.
This fixes that bug, and adds some tests.
(P.S. I realised how this was broken when working on #1313, IMO with this fix merged that PR becomes a lot less useful)
Checklist