chore: fix error tests listener registration #1291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
pauldambra
commented
Jul 8, 2024
| const decideResponse = { | ||
| editorParams: {}, | ||
| featureFlags: ['session-recording-player'], | ||
| supportedCompression: ['gzip-js'], | ||
| excludedDomains: [], | ||
| autocaptureExceptions: false, | ||
| ...decideResponseOverrides, | ||
| config: { ...decideResponseOverrides.config }, |
There was a problem hiding this comment.
nobody sends this, and DecideResponse doesn't have a config prop so 🔪
pauldambra
commented
Jul 8, 2024
| @@ -32,7 +32,7 @@ beforeEach(() => { | |||
|
|
|||
| cy.readFile('dist/recorder.js').then((body) => { | |||
| cy.intercept('/static/recorder.js*', { body }).as('recorder') | |||
| cy.intercept('/static/recorder-v2.js*', { body }).as('recorder') | |||
| cy.intercept('/static/recorder-v2.js*', { body }).as('recorderv2') | |||
There was a problem hiding this comment.
we should remove this tbh but fly-by rename so it doesn't clash
pauldambra
commented
Jul 8, 2024
| @@ -48,7 +48,7 @@ beforeEach(() => { | |||
| }) | |||
|
|
|||
| cy.readFile('dist/exception-autocapture.js').then((body) => { | |||
| cy.intercept('/static/exception-autocapture.js*', { body }) | |||
| cy.intercept('/static/exception-autocapture.js*', { body }).as('exception-autocapture-script') | |||
There was a problem hiding this comment.
better safe than sorry
|
Size Change: 0 B Total Size: 1.15 MB ℹ️ View Unchanged
|
daibhin
approved these changes
Jul 8, 2024
This was referenced Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I can't consistently make this happen locally
But I did once notice that I don't always get
i only noticed after the fact but if we didn't register an event listener then the tests wouldn't pass
i've checked console logs in prod for our team and don't see this so it's safe to patch in tests (🙈)