feat: add payload host denylist #1282
Merged
+200
−38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
pauldambra
commented
Jul 3, 2024
| import { NetworkRecordOptions } from '../../../../types' | ||
| import { isHostOnDenyList } from '../../../../extensions/replay/external/denylist' | ||
|
|
||
| describe('network host denylist', () => { |
There was a problem hiding this comment.
made me sad "we" weren't testing any network recorder code
|
Size Change: +4.67 kB (+0.41%) Total Size: 1.15 MB
ℹ️ View Unchanged
|
pauldambra
commented
Jul 3, 2024
There was a problem hiding this comment.
giving us a place we can start moving code out of the entrypoint file
as we do we should add a lint rule restricting what can import it
pauldambra
commented
Jul 3, 2024
Comment on lines
+19
to
+23
| const defaultNotDenied = { hostname, isHostDenied: false } | ||
|
|
||
| if (!options.payloadHostDenyList?.length || !hostname?.trim().length) { | ||
| return defaultNotDenied | ||
| } |
pauldambra
commented
Jul 3, 2024
| } | ||
|
|
||
| for (const deny of options.payloadHostDenyList) { | ||
| if (hostname.endsWith(deny)) { |
There was a problem hiding this comment.
went with endsWith over regex or something...
so that we can say e.g. .lr-ingest.io and not get any of their payloads
daibhin
approved these changes
Jul 3, 2024
This was referenced Jul 25, 2024
This was referenced Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've seen replay message be rejected for being too large
And on inspection they contain many megabytes of replay data for other vendors
There's no point capturing those payloads 🙈