Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: warn when distinct id invalid for replay #1277

Merged
merged 1 commit into from
Jun 28, 2024

Conversation

pauldambra
Copy link
Member

Copy link

vercel bot commented Jun 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
posthog-js ✅ Ready (Inspect) Visit Preview Jun 28, 2024 11:29am

Copy link

Size Change: +626 B (+0.06%)

Total Size: 1.11 MB

Filename Size Change
dist/array.full.js 315 kB +155 B (+0.05%)
dist/array.js 144 kB +157 B (+0.11%)
dist/main.js 144 kB +157 B (+0.11%)
dist/module.js 144 kB +157 B (+0.11%)
ℹ️ View Unchanged
Filename Size
dist/exception-autocapture.js 10.4 kB
dist/recorder-v2.js 109 kB
dist/recorder.js 109 kB
dist/surveys-preview.js 60.3 kB
dist/surveys.js 65 kB
dist/tracing-headers.js 8.26 kB
dist/web-vitals.js 5.79 kB

compressed-size-action

@pauldambra pauldambra added the bump patch Bump patch version when this PR gets merged label Jun 28, 2024
Copy link
Contributor

@daibhin daibhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we drop the events or is that too much?

@pauldambra
Copy link
Member Author

well, we're going to drop them at capture, and return a 400 (since the last couple of days changes) so I think we're ok with a log error to point someone at as well

currently this is only one customer, so even though it's pretty high volume from them, they seem to track latest version, so this will maybe help them understand what is happening 🙈

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump patch Bump patch version when this PR gets merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants