-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(web-analytics): Add property for autocapture link click #1259
Merged
robbie-c
merged 6 commits into
main
from
feat/create-property-for-autocapture-link-clicks
Jun 21, 2024
Merged
feat(web-analytics): Add property for autocapture link click #1259
robbie-c
merged 6 commits into
main
from
feat/create-property-for-autocapture-link-clicks
Jun 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Size Change: +64 B (+0.01%) Total Size: 1.01 MB
ℹ️ View Unchanged
|
robbie-c
force-pushed
the
feat/create-property-for-autocapture-link-clicks
branch
from
June 21, 2024 06:58
e60c7e5
to
0979804
Compare
mariusandra
approved these changes
Jun 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found a typo, otherwise looks good. Not 100% convinced of the property name, but got nothing better.
Co-authored-by: Marius Andra <[email protected]>
This was referenced Jul 13, 2024
This was referenced Jul 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR creates a new property, which is the href when an external link is clicked. External is defined as a different host, and the intention here is for people to measure things like which landing pages lead to which external link clicks.
(I was basically nerd-sniped into adding this by some customer feedback)
We already capture this, but it's very buried inside the $element array, and not always at the same place (not always $elements.0.attr_href), so its hard to add to the sessions MV.
Tested this manually by adding an external link to the nextjs playground, and confirming that I could see the event and property.
Checklist