Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: patch rrweb zero width canvas bug #1075

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

pauldambra
Copy link
Member

ran pnpm patch [email protected]
then added the fix from rrweb-io/rrweb#1422
then ran pnpm patch-commit the-location-the-patch-created-for-me

verified I can still record locally with it

@pauldambra pauldambra requested a review from a team March 12, 2024 13:49
@pauldambra
Copy link
Member Author

@daibhin I've never set up to be able to test canvas locally... do we have a demo file or ...... ?

Copy link

Size Change: +79 B (0%)

Total Size: 853 kB

Filename Size Change
dist/recorder-v2.js 106 kB +79 B (0%)
ℹ️ View Unchanged
Filename Size
dist/array.full.js 183 kB
dist/array.js 124 kB
dist/es.js 124 kB
dist/exception-autocapture.js 12.1 kB
dist/module.js 124 kB
dist/recorder.js 58.7 kB
dist/surveys-module-previews.js 62 kB
dist/surveys.js 58.3 kB

compressed-size-action

@daibhin
Copy link
Contributor

daibhin commented Mar 12, 2024

I was using this one when building it canvas.json. Now I tend to run the example app from posthog-js

@pauldambra pauldambra added the bump patch Bump patch version when this PR gets merged label Mar 12, 2024
@pauldambra pauldambra merged commit 48e6e7b into main Mar 12, 2024
14 checks passed
@pauldambra pauldambra deleted the fix/patch-rrweb-zero-width-canvas branch March 12, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump patch Bump patch version when this PR gets merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants