feat(feature-flags): support quota limiting for feature flags #403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR adds quota limiting support for feature flags in the PostHog JS Lite library, handling scenarios where users exceed their API usage limits.
- Added
quotaLimitedproperty toPostHogDecideResponsetype inposthog-core/src/types.tsto track which features are quota-limited - Implemented handling of 402 status codes in
posthog-node/src/feature-flags.tsto clear all local flags when quota is exceeded - Added test coverage in
posthog-core/test/posthog.featureflags.spec.tsto verify feature flags returnundefinedwhenquotaLimitedincludes 'feature_flags' - Modified
apiImplementationinposthog-node/test/test-utils.tsto support simulating quota limit responses withlocalFlagsStatusparameter
6 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
|
Size Change: +1.33 kB (+1.01%) Total Size: 133 kB
ℹ️ View Unchanged
|
marandaneto
reviewed
Feb 21, 2025
marandaneto
reviewed
Feb 21, 2025
…-js-lite into feat/quota-limited-flags
marandaneto
reviewed
Feb 23, 2025
| @@ -1225,7 +1249,7 @@ export abstract class PostHogCore extends PostHogCoreStateless { | |||
| return this._decideResponsePromise | |||
| } | |||
|
|
|||
| private setKnownFeatureFlags(featureFlags: PostHogDecideResponse['featureFlags']): void { | |||
| private setKnownFeatureFlags(featureFlags: PostHogDecideResponse['featureFlags'] | null): void { | |||
There was a problem hiding this comment.
since this and setKnownFeatureFlagPayloads accept null now, we can change the other places from:
this.setKnownFeatureFlags({})
this.setKnownFeatureFlagPayloads({})
to null values as well.
There was a problem hiding this comment.
I did this I believe; I grepped those methods and I am using null in the only place they're called.
marandaneto
approved these changes
Feb 23, 2025
|
before merging, lets figure this out PostHog/posthog-android#228 (comment) |
…-js-lite into feat/quota-limited-flags
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
with this PR, we now start to respond different with the
/decideand/local_evaluationAPIs if users have gone over their quota limit. Now we need to change the SDKs to handle these new responses.