address comment

feature-flags/src/redis.rs

@@ -43,7 +43,6 @@ impl Client for RedisClient {
 }
 
 // TODO: Find if there's a better way around this.
-// mockall got really annoying with async and results so I'm just gonna do my own
 #[derive(Clone)]
 pub struct MockRedisClient {
     zrangebyscore_ret: Vec<String>,

feature-flags/src/router.rs

@@ -13,14 +13,6 @@ pub struct State {
 pub fn router<R: Client + Send + Sync + 'static>(redis: Arc<R>) -> Router {
     let state = State { redis };
 
-    // // Very permissive CORS policy, as old SDK versions
-    // // and reverse proxies might send funky headers.
-    // let cors = CorsLayer::new()
-    //     .allow_methods([Method::GET, Method::POST, Method::OPTIONS])
-    //     .allow_headers(AllowHeaders::mirror_request())
-    //     .allow_credentials(true)
-    //     .allow_origin(AllowOrigin::mirror_request());
-
     Router::new()
         .route("/flags", post(v0_endpoint::flags).get(v0_endpoint::flags))
         .with_state(state)

feature-flags/tests/common.rs

@@ -28,7 +28,7 @@ pub struct ServerHandle {
 
 impl ServerHandle {
     pub async fn for_config(config: Config) -> ServerHandle {
-        let listener = TcpListener::bind("127.0.0.1:3001").await.unwrap();
+        let listener = TcpListener::bind("127.0.0.1:0").await.unwrap();
         let addr = listener.local_addr().unwrap();
         let notify = Arc::new(Notify::new());
         let shutdown = notify.clone();