Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add topology spread constraint snippet to all deployments #777

Merged
merged 4 commits into from
Oct 31, 2023

Conversation

frankh
Copy link
Contributor

@frankh frankh commented Oct 30, 2023

Description

Include a new "topologySpreadConstraint" snippet to all deployments

By default it won't be included, but if you set .Values.includeDefaultTopologySpreadConstraints it will add a topologySpreadConstraint to all deployments to balance pods between availability zones and hosts

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

How has this been tested?

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@frankh frankh requested review from ellie and danielxnj October 30, 2023 15:57
@frankh frankh force-pushed the frank/add-topology-spread-constraints branch 2 times, most recently from d7513a1 to fdda70b Compare October 30, 2023 16:03
@frankh frankh force-pushed the frank/add-topology-spread-constraints branch from 87fac83 to 5ae2946 Compare October 30, 2023 16:43
In the case of a full AZ outage we won't be able to schedule new pods otherwise
@frankh frankh force-pushed the frank/add-topology-spread-constraints branch from 06023a8 to e47de33 Compare October 30, 2023 16:55
@frankh frankh merged commit 183dec1 into main Oct 31, 2023
46 of 48 checks passed
@frankh frankh deleted the frank/add-topology-spread-constraints branch October 31, 2023 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant